test(ghcr-example-supply-chain-app): fix missing patch @ionic-native #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zondervancalvez
requested review from
petermetz,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
@zondervancalvez codegen is failing |
petermetz
requested changes
Nov 26, 2024
There was a problem hiding this comment.
@zondervancalvez Looking good in general but I have a few nits:
- If you need the NodeJS upgrade then please explain why. Otherwise remove it.
- The
.yarn/directory is 700 MB. The patch that is in it is only a few KB. Could you please try to only include the patch file with an otherwise empty .yarn/ directory so we don't have to increase the image size by this much just for the little patch.
zondervancalvez
force-pushed
the
zondervancalvez/issue3601
branch
from
7a16672 to
afec444
Compare
petermetz
approved these changes
Dec 5, 2024
|
@hyperledger-cacti/cacti-maintainers bump |
outSH
approved these changes
Dec 6, 2024
Primary Changes ---------------- 1. Updated the NVM version to 20.11.1 and added the necessary yarn patch path to build the image Fixes hyperledger-cacti#3601 Signed-off-by: bado <[email protected]>
petermetz
force-pushed
the
zondervancalvez/issue3601
branch
from
afec444 to
86fa274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
test(ghcr-example-supply-chain-app): fix missing patch @ionic-native
Fixes #3601
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.